| commit | 7f4f506493d114e2fbf84ccef06e6cc765e836da | [log] [tgz] |
|---|---|---|
| author | Daniel Santiago Rivera <danysantiago@google.com> | Thu Jun 05 10:08:37 2025 -0400 |
| committer | Android Build Coastguard Worker <android-build-coastguard-worker@google.com> | Mon Jun 16 11:01:36 2025 -0700 |
| tree | 40852a8bb7833acb977c8f0a41ab9c777ec67a35 | |
| parent | 9ac763dbab4716fd829fd6ca33c08077b2321c69 [diff] |
Log connection timeout instead of throwing The original idea of using withTimeout while acquiring a connection was to prevent deadlocks due to a coroutine never releasing a connection. This change updates the pool to just log the busy exception that would have been thrown in order to help developers if they notice a deadlock but not crash the app. The change from throwing to logging is done to support iOS looper suspension. Kotlin Coroutines rely on iOS Foundation timers and those themselves rely on Run Loops. When an iOS app is backgrounded the process is suspended along with the loopers, when the app is resumed all events that would have triggered while the app was in the background are immediately fired, causing Room to throw the timeout exception if there was a coroutine waiting for a connection before the app was suspended. The timeout in Room is meant to represent time waiting for a connection while the process is active, not clock time. In order to support active only timeouts we would need listeners for foreground / background states changes but those are not accessible at the layer where Room operates, therefore instead of throwing Room will just log and even though it might log false-positives when the app is resumed it will not crash the app and the log will still be useful if there is a real deadlock. Bug: 380088809 Bug: 422448815 Test: BundledSQLiteConnectionPoolTest (cherry picked from https://android-review.googlesource.com/q/commit:a1ea1d8a577d858b1d2bdb301cd28a1efcb008aa) (cherry picked from https://android-review.googlesource.com/q/commit:c9b0c6beb5dd96c8ad198a226c1763bd577580cf) Merged-In: I78a29565acc98d6ff8d2074efe965b0fa570aef2 Change-Id: I78a29565acc98d6ff8d2074efe965b0fa570aef2
Jetpack is a suite of libraries, tools, and guidance to help developers write high-quality apps easier. These components help you follow best practices, free you from writing boilerplate code, and simplify complex tasks, so you can focus on the code you care about.
Jetpack comprises the androidx.* package libraries, unbundled from the platform APIs. This means that it offers backward compatibility and is updated more frequently than the Android platform, making sure you always have access to the latest and greatest versions of the Jetpack components.
Our official AARs and JARs binaries are distributed through Google Maven.
You can learn more about using it from Android Jetpack landing page.
For contributions via GitHub, see the GitHub Contribution Guide.
Note: The contributions workflow via GitHub is currently experimental - only contributions to the following projects are being accepted at this time:
When contributing to Jetpack, follow the code review etiquette.
We are not currently accepting new modules.
Head over to the onboarding docs to learn more about getting set up and the development workflow!
Our continuous integration system builds all in progress (and potentially unstable) libraries as new changes are merged. You can manually download these AARs and JARs for your experimentation.
Before uploading your first contribution, you will need setup a password and agree to the contribution agreement:
Generate a HTTPS password: https://android-review.googlesource.com/new-password
Agree to the Google Contributor Licenses Agreement: https://android-review.googlesource.com/settings/new-agreement
AndroidX uses git to store all the binary Gradle dependencies. They are stored in prebuilts/androidx/internal and prebuilts/androidx/external directories in your checkout. All the dependencies in these directories are also available from google(), or mavenCentral(). We store copies of these dependencies to have hermetic builds. You can pull in a new dependency using our importMaven tool.