Work around CORS issues with jsdom in auth/hub emulators. #3224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuchenshi
commented
Mar 19, 2021
| @@ -92,6 +92,7 @@ | |||
| "cli-table": "^0.3.1", | |||
| "commander": "^4.0.1", | |||
| "configstore": "^5.0.1", | |||
| "cors": "^2.8.5", | |||
There was a problem hiding this comment.
This is tricker than I thought, and I'm glad someone else solved it already. This adds 6KiB download size only, mainly due to vary (but we'd need to handle that anyway). This is also already a dependency in Firebase Functions SDK.
bkendall
approved these changes
Mar 19, 2021
devpeerapong
pushed a commit
to devpeerapong/firebase-tools
that referenced
this pull request
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3200.
Scenarios Tested
See tests added.
Sample Commands
N/A